Do I need a vapor barrier?

A vapor barrier has no place on either side of a cavity. Air tight, vapor variable membranes that allow for efficiency along with an escape route for inevitable moisture are certainly becoming a best practice. They can go on either side of the cavity and should definitely go on the outside if you have to pick one.